-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(twap): avoid sending env
as undefined
to getOrder query
#2864
Conversation
Without this, instead of the default behaviour, the SDK defaults to `barn` endpoint
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
: undefined), | ||
} | ||
|
||
return orderBookApi.getOrder(orderId, contextOverride) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should fix in the SDK too, should default to prod
: undefined), | ||
} | ||
|
||
return orderBookApi.getOrder(orderId, contextOverride) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should fix in the SDK too, should default to prod
merging, just to consolidate all these pending PRs |
Summary
Avoid sending
env
asundefined
to getOrder queryWithout this, instead of the default behaviour, the SDK defaults to
barn
endpointTo Test
api.cow.fi
endpointstaging
, there should be no /orders/ requests tobarn.api.cow.fi
endpoint